-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NoMethodError in backend #364
Conversation
- IRB v1.15.0 renamed build_statement -> parse_input
This addresses the issue reported in #363 |
LGTM - would be nice to see the test suite pass aside from the Ruby 3.4 issue. Also, a release would be nice so that users can take advantage of these revisions without needing to install from master. |
@irb.context.last_value unless IRuby.silent_assignment && assignment_expression?(code) | ||
end | ||
|
||
def parse_code(code) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method could be moved down to the private methods.
@edsinclair Thank you! @sealocal |
@sealocal |
@sealocal I've invited you as a developer of IRuby. Welcome! |
Got it! Thank you! |
I didn't include any new tests as this existing test was failing when run with IRB >= 1.15.0