Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: align dialect definition with data package v2 #59

Merged
merged 3 commits into from
Dec 22, 2024

Conversation

Seddryck
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.49618% with 19 lines in your changes missing coverage. Please review.

Project coverage is 82.33%. Comparing base (cb4f8bc) to head (0edaedb).

Files with missing lines Patch % Lines
...svReader/Configuration/DialectDescriptorBuilder.cs 88.46% 3 Missing ⚠️
...Reader/CharParsing/FirstCharOfFieldLookupParser.cs 75.00% 1 Missing and 1 partial ⚠️
...ketCsvReader/CharParsing/FirstCharOfFieldParser.cs 50.00% 0 Missing and 2 partials ⚠️
...Reader/CharParsing/FirstCharOfQuotedFieldParser.cs 50.00% 0 Missing and 2 partials ⚠️
PocketCsvReader/CsvArrayString.cs 83.33% 0 Missing and 2 partials ⚠️
PocketCsvReader/CsvDataReader.cs 84.61% 0 Missing and 2 partials ⚠️
...etCsvReader/CharParsing/CharOfFieldLookupParser.cs 75.00% 0 Missing and 1 partial ⚠️
PocketCsvReader/CharParsing/CharOfFieldParser.cs 50.00% 1 Missing ⚠️
...etCsvReader/CharParsing/FirstCharOfRecordParser.cs 93.33% 0 Missing and 1 partial ⚠️
PocketCsvReader/Configuration/DialectDescriptor.cs 94.44% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   81.36%   82.33%   +0.96%     
==========================================
  Files          40       40              
  Lines        1111     1155      +44     
  Branches      194      211      +17     
==========================================
+ Hits          904      951      +47     
+ Misses        160      148      -12     
- Partials       47       56       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Seddryck Seddryck merged commit e1641b5 into main Dec 22, 2024
5 checks passed
@Seddryck Seddryck deleted the feat/data-package-v2-dialect branch December 22, 2024 16:32
@Seddryck Seddryck added the new-feature Request for a new feature in the tool label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Request for a new feature in the tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants