Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve coherency and robusteness of CsvDataReader #83

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

Seddryck
Copy link
Owner

@Seddryck Seddryck commented Jan 5, 2025

  • this[] returns the same value than GetValue
  • GetFieldValue also works when no schema is defined.
  • FieldType returns object when no schema is defined or field is not defined

- this[] returns the same value than GetValue
- GetFieldValue also works when no schema is defined.
- FieldType returns object when no schema is defined or field is not defined
@Seddryck Seddryck force-pushed the fix/CsvDataReader-this-getFieldValue branch from 576473d to 64895e2 Compare January 5, 2025 16:32
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.99%. Comparing base (f15eb30) to head (64895e2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
PocketCsvReader/CsvDataReader.cs 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   81.13%   81.99%   +0.86%     
==========================================
  Files          46       46              
  Lines        1362     1355       -7     
  Branches      247      243       -4     
==========================================
+ Hits         1105     1111       +6     
+ Misses        181      173       -8     
+ Partials       76       71       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Seddryck Seddryck merged commit 86360d5 into main Jan 5, 2025
5 checks passed
@Seddryck Seddryck deleted the fix/CsvDataReader-this-getFieldValue branch January 5, 2025 16:50
@Seddryck Seddryck added the bug Something isn't working label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants