Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Library): add interface and menus to select install location #419

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

ShadowApex
Copy link
Collaborator

@ShadowApex ShadowApex commented Dec 27, 2024

This change adds a new method to the Library class to install a library item to a specified location and with arbitrary install options. It also includes new menus to select the install location and options:

Screenshot From 2025-01-15 23-40-41

Screenshot From 2025-01-16 00-25-33

Fixes #97

@ShadowApex ShadowApex requested a review from pastaq December 27, 2024 04:57
@pastaq
Copy link
Collaborator

pastaq commented Dec 27, 2024

Is there more planned for this or is it ready?

@ShadowApex
Copy link
Collaborator Author

Is there more planned for this or is it ready?

I still need to create the menu interface for selecting an install location. Once that's done, this should be ready.

@ShadowApex ShadowApex force-pushed the shadowapex/install-location branch 2 times, most recently from eba232a to f9111ac Compare January 16, 2025 08:22
@ShadowApex ShadowApex marked this pull request as ready for review January 16, 2025 08:28
@ShadowApex ShadowApex requested a review from pastaq January 16, 2025 08:28
@ShadowApex ShadowApex force-pushed the shadowapex/install-location branch 2 times, most recently from 3032c5c to 7b05cc2 Compare January 16, 2025 08:39
Copy link
Collaborator

@pastaq pastaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll test and get back to you.

@ShadowApex ShadowApex force-pushed the shadowapex/install-location branch from 7b05cc2 to e27b64c Compare January 19, 2025 00:55
@ShadowApex ShadowApex force-pushed the shadowapex/install-location branch from e27b64c to 25aff52 Compare March 11, 2025 06:34
@ShadowApex ShadowApex merged commit 9f72bb4 into main Mar 11, 2025
2 checks passed
@ShadowApex ShadowApex deleted the shadowapex/install-location branch March 11, 2025 06:35
Copy link

🎉 This PR is included in version 0.37.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement interface to select game installation location
2 participants