Custom elements should have class set instead of className in React (#…

…966)
Shopify · May 30, 2023 · 93a7c3c · 93a7c3c
1 parent be912b2
commit 93a7c3c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/silver-buckets-obey.md b/.changeset/silver-buckets-obey.md
@@ -0,0 +1,6 @@
+---
+'@shopify/hydrogen-react': patch
+'@shopify/hydrogen': patch
+---
+
+Fix `<ModelViewer>` to properly set className
diff --git a/packages/hydrogen-react/src/ModelViewer.tsx b/packages/hydrogen-react/src/ModelViewer.tsx
@@ -221,10 +221,11 @@ export function ModelViewer(props: ModelViewerProps): JSX.Element | null {
 
   return (
     <model-viewer
-      // @ts-expect-error ref should exist
       ref={callbackRef}
       {...passthroughProps}
-      className={className}
+      // @ts-expect-error src should exist
+      // @eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+      class={className}
       id={passthroughProps.id ?? data.id}
       src={data.sources[0].url}
       alt={data.alt ?? null}