Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the starter template blog route to include a required startCursor in the GraphQL query. #1441

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

blittle
Copy link
Contributor

@blittle blittle commented Oct 20, 2023

WHY are these changes introduced?

The Pagination component requires both startCursor and endCursor. We forgot to update the blogs/$blogHandle route to query the startCursor.

Fixes #1337

WHAT is this pull request doing?

HOW to test your changes?

Start the skeleton template and load the a blog

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@blittle blittle merged commit d2f4737 into main Oct 20, 2023
@blittle blittle deleted the bl-1337 branch October 20, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skeleton template News index page throws pagination error
2 participants