Add h2 shortcut with shell aliases #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartogram
reviewed
Mar 13, 2023
There was a problem hiding this comment.
Testing locally worked (Mac only)! The code here is still a bit confusing to me because I don't have a lot of knowledge about shell/OS stuff, but the code is easy enough to follow. I think this strikes a better balance for this feature wrt longer-term support. Do you mind adding some tests as well? Enough to mock each platform and assert that the various branches do what they should.
🚀 🚀 Thanks for continuing to push this forward!
This comment has been minimized.
This comment has been minimized.
|
🎉🎉 |
blittle
reviewed
Mar 28, 2023
| } | ||
|
|
||
| // Create a PowerShell function and an alias to call it. | ||
| const PS_FUNCTION = `function Invoke-Local-H2 {$npmPrefix = npm prefix -s; Invoke-Expression "$npmPrefix\\node_modules\\.bin\\shopify.ps1 hydrogen $Args"}; Set-Alias -Name ${ALIAS_NAME} -Value Invoke-Local-H2`; |
There was a problem hiding this comment.
You are a powershell ninja
blittle
approved these changes
Mar 28, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #430 but only creating aliases at the shell level. Something similar to
alias h2='$(npm bin)/shopify hydrogen'in ZSH/Bash.🎩 :
cd templates/hello-worldnpx shopify hydrogen shortcut<-- creates the shell h2 aliash2 g r cartNotes:
static aliaseswork in Oclif. No idea why, it just ignores them.