Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart abstraction #786

Merged
merged 86 commits into from
Jul 5, 2023
Merged

Cart abstraction #786

merged 86 commits into from
Jul 5, 2023

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented Apr 13, 2023

Create a cart abstraction with Remix mindset:

  • All queries are working, still need to add cart note and select delivery mutations
  • Had some trouble putting the <CartForm> component with @shopify/hydrogen

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@benjaminsehl
Copy link
Member

Just reviewing some old issues and wanted to tag this one on this PR for us to consider: #113

Not necessary to solve for at this moment but worth us revisiting as we go through build @mynameisadamf

@wizardlyhel wizardlyhel changed the base branch from 2023-01 to 2023-04 April 18, 2023 16:57
@github-actions github-actions bot had a problem deploying to preview June 22, 2023 22:33 Failure
@github-actions github-actions bot had a problem deploying to preview July 4, 2023 21:58 Failure
@wizardlyhel wizardlyhel merged commit 4c0858f into 2023-04 Jul 5, 2023
@wizardlyhel wizardlyhel deleted the hl-cart branch July 5, 2023 19:19
juanpprieto pushed a commit that referenced this pull request Jul 10, 2023
FrcPpe pushed a commit to FrcPpe/hydrogen that referenced this pull request Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants