Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up old deprecated_references.yml files automatically #301

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

gmcgibbon
Copy link
Member

What are you trying to accomplish?

Cleanup old deprecated references automatically.

What approach did you choose and why?

When running update-todo on an old set of packages, clean up old deprecated_references.yml files automatically because package_todo.yml will be dumped and used as the replacement.

What should reviewers focus on?

I forgot to release the deprecation of update-deprecations, so once this is approved I will be shipping another version of 2.x that introduces (along with using update-todo instead of update-deprecations) this and the deprecations in preparation for 3.0s release.

Type of Change

  • Bugfix
  • New feature
  • Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)

Additional Release Notes

  • Breaking change (fix or feature that would cause existing functionality to change)

Include any notes here to include in the release description. For example, if you selected "breaking change" above, leave notes on how users can transition to this version.

If no additional notes are necessary, delete this section or leave it unchanged.

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • It is safe to rollback this change.

When running update-todo on an old set of packages, clean up old
deprecated_references.yml files automatically because package_todo.yml
will be dumped and used as the replacement.
@gmcgibbon gmcgibbon requested a review from a team as a code owner February 9, 2023 02:30
Copy link

@iwz iwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmcgibbon gmcgibbon merged commit 724ff1e into main Feb 10, 2023
@gmcgibbon gmcgibbon deleted the deprecated_references_cleanup branch February 10, 2023 22:21
gmcgibbon added a commit that referenced this pull request Feb 21, 2023
Clean up old deprecated_references.yml files automatically
gmcgibbon added a commit that referenced this pull request Feb 21, 2023
Clean up old deprecated_references.yml files automatically
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems March 1, 2023 19:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants