This repository was archived by the owner on Apr 13, 2022. It is now read-only.
Update color variants to match Figma #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahill
changed the title
|
@danrosenthal What's a good workflow for quickly getting seeing the final tokens, calculated using the adjustments made in this PR? I.e. In the same format as this file. I've tried both this branch and |
sarahill
requested review from
kyledurand and
tmlayton
and removed request for
tmlayton,
danrosenthal and
kyledurand
martenbjork
approved these changes
Feb 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're working to stabilize colors between tokens and Figma. This PR adjust the lightness values of some variants to match the visual style.
This spreadsheet will die once the changes are made. Using this to compare values and document updates as I go.
https://docs.google.com/spreadsheets/d/1VtebqhKrVD9l90O4veYFcH86D9xiZxeuSt-IWTew6yc/edit?usp=sharing