Skip to content
This repository was archived by the owner on Apr 13, 2022. It is now read-only.

Update color-blue to #006fbb #63

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Update color-blue to #006fbb #63

merged 1 commit into from
Jun 6, 2019

Conversation

alex-page
Copy link
Member

@alex-page alex-page commented Jun 4, 2019

This changes color-blue to #006fbb from #007ace so that our link color passes contrast 4.5 on our currently darkest background colour #fbeae5.

This will allow these issues to be closed:

  • Style guide
  • Sketch UI Kit cc @sarahill
  • Sketch palette
  • Icons Sketch Kit
  • Figma styles @HYPD

@HYPD
Copy link

HYPD commented Jun 4, 2019

@alex-page has this been updated everywhere?

  • Style guide
  • Sketch UI Kit cc @sarahill
  • Sketch palette
  • Figma styles (I can do this)
  • Anywhere else we do this

@kaelig
Copy link
Contributor

kaelig commented Jun 4, 2019

cc @jessebc, as creative direction owns the palette.

@alex-page
Copy link
Member Author

alex-page commented Jun 5, 2019

For context this should not be a "visual" change. It is shifting the lightness of the color-blue to make it 3% darker so that it meets accessibility across all of our light background colours. I would be surprised if the change can be visually perceived.

Currently our blue link colour is failing colour contrast on white, light grey and our darkest background colour the light red.

The new blue was chosen by finding the closest passing colour with the existing blue and the darkest background light red using this tool:
http://accessible-colors.com/

@alex-page alex-page requested a review from jessebc June 5, 2019 00:21
Copy link

@jessebc jessebc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disappointed that we'll lose the James Bond hex code... but seems for the better.

@sarahill
Copy link
Contributor

sarahill commented Jun 5, 2019

I think the style guide will get the color updates once this PR is merged. Correct me if I'm wrong @HYPD @alex-page

@kaelig
Copy link
Contributor

kaelig commented Jun 5, 2019

To be fully thorough we would look at all the styleguide images and modify those that include this blue to relfect the change, but that's probably a lot of work for very little return. Thoughts?

When it comes to the color palette shown in the style guide, a dependency update is all that's needed.

@sarahill
Copy link
Contributor

sarahill commented Jun 5, 2019

I feel like updating all the images would be little impact. Let's take the time to update it in the kits and palettes where the colors will be pulled from but images seem low for this particular update.

Open to other opinions on this though. That's just my initial thought.

@alex-page
Copy link
Member Author

For this change unless the image has the hexadecimal value in it I would avoid changing it. This is not meant to be visually perceived as different from the previous colour.

@HYPD
Copy link

HYPD commented Jun 6, 2019

@alex-page Figma styles updated

Copy link
Contributor

@kaelig kaelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the CSS filter for this color too.

Also, why did the yellow dark filter change?

@alex-page
Copy link
Member Author

alex-page commented Jun 6, 2019

@kaelig not sure why the change to colorYellowDark is happening. If I run the instructed commands locally in master branch, I can also see the change to colorYellowDark:

yarn get-tokens-from-invision-dsm
yarn dist
yarn test -u

Maybe the colour was updated accidentally in invision DSM or it was never updated in the tokens after an intentional change. Is there a way to see history in DSM?

The colour filter was added in the original commit.

@@ -29,7 +29,7 @@ color-blue-darker:
color-blue-dark:
filter: brightness(0) saturate(100%) invert(22%) sepia(70%) saturate(1308%) hue-rotate(182deg) brightness(94%) contrast(101%)
color-blue:
filter: brightness(0) saturate(100%) invert(32%) sepia(99%) saturate(1186%) hue-rotate(181deg) brightness(91%) contrast(103%)
filter: brightness(0) saturate(100%) invert(19%) sepia(98%) saturate(2885%) hue-rotate(190deg) brightness(99%) contrast(101%);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaelig filter added here, following docs:

When updating a color, please also remember to update its filter metadata. Filter values can be generated using this CodePen and are stored in /data/color-metadata.yml.

@kaelig
Copy link
Contributor

kaelig commented Jun 6, 2019

I looked into it, and it seems like #44 didn't update the filter for yellow-dark, hence why it appears in this PR.

@alex-page alex-page merged commit b260699 into master Jun 6, 2019
@alex-page alex-page deleted the color-blue-contrast branch June 6, 2019 20:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants