-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
@alex-page has this been updated everywhere?
|
cc @jessebc, as creative direction owns the palette. |
For context this should not be a "visual" change. It is shifting the lightness of the Currently our blue link colour is failing colour contrast on white, light grey and our darkest background colour the light red. The new blue was chosen by finding the closest passing colour with the existing blue and the darkest background light red using this tool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disappointed that we'll lose the James Bond hex code... but seems for the better.
I think the style guide will get the color updates once this PR is merged. Correct me if I'm wrong @HYPD @alex-page |
To be fully thorough we would look at all the styleguide images and modify those that include this blue to relfect the change, but that's probably a lot of work for very little return. Thoughts? When it comes to the color palette shown in the style guide, a dependency update is all that's needed. |
I feel like updating all the images would be little impact. Let's take the time to update it in the kits and palettes where the colors will be pulled from but images seem low for this particular update. Open to other opinions on this though. That's just my initial thought. |
For this change unless the image has the hexadecimal value in it I would avoid changing it. This is not meant to be visually perceived as different from the previous colour. |
@alex-page Figma styles updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the CSS filter for this color too.
Also, why did the yellow dark filter change?
@kaelig not sure why the change to yarn get-tokens-from-invision-dsm
yarn dist
yarn test -u Maybe the colour was updated accidentally in invision DSM or it was never updated in the tokens after an intentional change. Is there a way to see history in DSM? The colour filter was added in the original commit. |
@@ -29,7 +29,7 @@ color-blue-darker: | |||
color-blue-dark: | |||
filter: brightness(0) saturate(100%) invert(22%) sepia(70%) saturate(1308%) hue-rotate(182deg) brightness(94%) contrast(101%) | |||
color-blue: | |||
filter: brightness(0) saturate(100%) invert(32%) sepia(99%) saturate(1186%) hue-rotate(181deg) brightness(91%) contrast(103%) | |||
filter: brightness(0) saturate(100%) invert(19%) sepia(98%) saturate(2885%) hue-rotate(190deg) brightness(99%) contrast(101%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaelig filter added here, following docs:
When updating a color, please also remember to update its filter metadata. Filter values can be generated using this CodePen and are stored in /data/color-metadata.yml.
I looked into it, and it seems like #44 didn't update the filter for yellow-dark, hence why it appears in this PR. |
This changes
color-blue
to#006fbb
from#007ace
so that our link color passes contrast 4.5 on our currently darkest background colour#fbeae5
.This will allow these issues to be closed: