Skip to content

Commit f91c4b6

Browse files
alex-pagesam-b-roseaaronccasanovabratsos
authored
@shopify/polaris-icons v8.0.0 (#11138)
> [!Warning] > This includes multiple breaking changes to `@shopify/polaris-icons`. Do not merge until this is thoroughly tested and approved by internal consuming teams. ### What this PR does Removed Major and Minor icon sizing. All icons are the same size. Added `BillIcon`, `BillFilledIcon`, `LogoCriteo`, `LogoMeta`, `LogoGoogle`, `MetaobjectFilledIcon`, `PriceListIcon` and `PriceListFilledIcon` Updated icon design for `JobsIcon`, `JobsFilledIcon`, `AutomationIcon`, `AutomationFilledIcon`, `GiftCardIcon`, `InventoryFilledIcon`, `ReportsIcon`, `ShipmentFilledIcon`, `AppsFilledIcon`, `MarketsIcon`, `MarketsFilledIcon`, `BillingStatementDollarFilledIcon`, `BillingStatementEuroFilledIcon`, `BillingStatementPoundFilledIcon`, `BillingStatementRupeeFilledIcon`, `BillingStatementYenFilledIcon`, `LegalFilledIcon`, `IdentityCardIcon`, `IdentityCardFilledIcon`, `DomainsIcon`, `DomainNewIcon`, `DomainsFilledIcon`, `StoreIcon`, `OnlineStoreIcon`, `ManagedStoreIcon`, `ImportStoreIcon`, `TaxIcon`, `TaxFilledIcon`, `PackageFilledIcon`, `LocationIcon`, `LocationFilledIcon`, `InactiveLocationIcon`, `PinIcon`, `GlobeIcon`, `TransportIcon`, `NatureIcon`, `FoodIcon`, `ColorsIcon` Removed icons `ReportFilledMinor`, `ReportMinor`, `ListMajor`, `ListFilledMajor` Removed `version` and `set` from icon `.yml` files --- Closes #11259 Closes #11088 --------- Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com> Co-authored-by: Aaron Casanova <aaron.casanova@shopify.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> Co-authored-by: Alex Bratsos <12677111+bratsos@users.noreply.github.com>
1 parent 297c69e commit f91c4b6

File tree

2,017 files changed

+12747
-9966
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

2,017 files changed

+12747
-9966
lines changed

.changeset/heavy-cougars-listen.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/polaris-migrator': minor
3+
---
4+
5+
Added `icons-v8-update-names` migration. This migration will update all icons from `@shopfiy/polaris-icons` from the deprecated Major and Minor suffixes to the new Icon suffix (ex: `AppsMajor` -> `AppsIcon`).

.changeset/wild-ties-join.md

+1,047
Large diffs are not rendered by default.

.github/CODEOWNERS

-2
This file was deleted.

.github/ISSUE_TEMPLATE/NEW_ICON.yml

-10
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,6 @@ body:
2020
label: Icon name
2121
validations:
2222
required: true
23-
- type: dropdown
24-
id: icon-set
25-
attributes:
26-
label: What type of icon set?
27-
options:
28-
- Major (20x20)
29-
- Minor (16x16)
30-
- Unsure
31-
validations:
32-
required: true
3323
- type: textarea
3424
id: icon-description
3525
attributes:

.github/ISSUE_TEMPLATE/UPDATE_ICON.yml

-10
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,6 @@ body:
2020
label: Icon name
2121
validations:
2222
required: true
23-
- type: dropdown
24-
id: icon-set
25-
attributes:
26-
label: What type of icon set?
27-
options:
28-
- Major (20x20)
29-
- Minor (16x16)
30-
- Unsure
31-
validations:
32-
required: true
3323
- type: textarea
3424
id: icon-figma-link
3525
attributes:

polaris-icons/CONTRIBUTING.md

-27
Original file line numberDiff line numberDiff line change
@@ -25,30 +25,3 @@ If you can’t find the icons you need, you can [propose new icons](https://gith
2525
## Proposing updates to existing icons
2626

2727
If you notice existing icons that are out-of-date or need improvements, you can [propose an update](https://github.com/Shopify/polaris/issues/new?assignees=&labels=Icon&template=UPDATE_ICON.yml&title=%5BIcon%5D%3A+Update+icon+%3Cicon-name%3E) to these icons.
28-
29-
## Deprecation guidelines
30-
31-
Sometimes icons need to be renamed or removed. Both of these actions are breaking changes from a developer’s perspective. In order to not erode trust with our consumers and ensure painless update paths we will reduce the impact of these breaking changes by batching them up.
32-
33-
### Deleting an icon
34-
35-
When you deprecate an icon with no replacement (that is, the icon should be deleted in the future), add `deprecated: true` to the icon’s metadata:
36-
37-
```yml
38-
deprecated: true
39-
```
40-
41-
### Renaming an icon
42-
43-
When you deprecate an icon with a replacement (that is, you rename an icon), rename the icon’s SVGs and metadata file, then add a `deprecated_aliases` key to the metadata with an array containing each of the icon’s previous names. For instance, if you were to rename `OldMajor.yml` to `NewMajor.yml`, add these lines to `NewMajor.yml`:
44-
45-
```yml
46-
# NewMajor.yml
47-
---
48-
deprecated_aliases:
49-
- OldMajor
50-
```
51-
52-
This will maintain an export with the original name but mark it as deprecated and instruct consumers to use the new name.
53-
54-
Every 6 months or so, we’ll consider releasing a new major version that removes any deprecated icons and aliases.

polaris-icons/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,13 @@ Import the [`Icon`](https://polaris.shopify.com/components/images-and-icons/icon
4040
2. Import an icon from Polaris icons:
4141

4242
```tsx
43-
import {AddMajor} from '@shopify/polaris-icons';
43+
import {PlusIcon} from '@shopify/polaris-icons';
4444
```
4545

4646
3. Pass the imported Polaris icon to the `source` prop of the `Icon` component:
4747

4848
```tsx
49-
<Icon source={AddMajor} />
49+
<Icon source={PlusIcon} />
5050
```
5151

5252
### SVG files

polaris-icons/icons/AbandonedCartFilledMajor.yml

-13
This file was deleted.

polaris-icons/icons/AbandonedCartMajor.yml

-14
This file was deleted.

polaris-icons/icons/AccessibilityMajor.yml

-18
This file was deleted.

polaris-icons/icons/ActivitiesMajor.yml

-16
This file was deleted.

polaris-icons/icons/AddCodeMajor.yml

-12
This file was deleted.

polaris-icons/icons/AddImageMajor.yml

-12
This file was deleted.

polaris-icons/icons/AddMajor.yml

-14
This file was deleted.

polaris-icons/icons/AddNoteMajor.yml

-12
This file was deleted.

polaris-icons/icons/AddProductMajor.yml

-14
This file was deleted.
File renamed without changes.

polaris-icons/icons/AdjustIcon.yml

+14
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
name: Adjust
2+
description: Used to denote that an adjustment can be made.
3+
keywords:
4+
- adjust
5+
- adjustment
6+
- controls
7+
- dials
8+
authors:
9+
- James Findlater
10+
- Chris Poirier
11+
- Lauren Mayers
12+
- Joe Thomas
13+
date_added: 2022-02-02
14+
date_modified: 2023-06-23

polaris-icons/icons/AdjustMinor.yml

-17
This file was deleted.
File renamed without changes.

polaris-icons/icons/AffiliateIcon.yml

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
name: Affiliate
2+
authors:
3+
- Joe Thomas
4+
description: N/A
5+
keywords:
6+
- N/A
7+
date_added: 2019-03-15
8+
date_modified: 2023-06-23

polaris-icons/icons/AffiliateMajor.yml

-12
This file was deleted.

polaris-icons/icons/AirplaneIcon.svg

+1
Loading

polaris-icons/icons/AirplaneIcon.yml

+14
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
name: Airplane
2+
description: Used as a navigation item in our emoji picker for the transport category.
3+
keywords:
4+
- transport
5+
- plane
6+
- airplane
7+
- emoji
8+
- navigation
9+
authors:
10+
- Adam Whitcroft
11+
- Joe Thomas
12+
- José Torre
13+
date_added: 2019-03-15
14+
date_modified: 2023-11-07
File renamed without changes.
+10
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
name: Alert bubble
2+
description: Used to represent a dispute or important conversation or notification.
3+
keywords:
4+
- dispute
5+
- claim
6+
authors:
7+
- Adam Whitcroft
8+
- Joe Thomas
9+
date_added: 2018-11-14
10+
date_modified: 2023-06-23
+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
name: Alert circle
2+
description: Used to alert merchants of a warning message.
3+
keywords:
4+
- attention
5+
- alert
6+
- warning
7+
- exclamation
8+
- bang
9+
- circle
10+
- round
11+
authors:
12+
- Adam Whitcroft
13+
- Joe Thomas
14+
date_added: 2019-02-21
15+
date_modified: 2023-06-23
+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
name: Alert diamond
2+
description: Used to alert merchants of a critical error.
3+
keywords:
4+
- alert
5+
- attention
6+
- critical
7+
- diamond
8+
- error
9+
- exclamation
10+
- bang
11+
authors:
12+
- Jesse Bennett-Chamberlain
13+
- Joe Thomas
14+
date_added: 2023-01-16
15+
date_modified: 2023-06-23

polaris-icons/icons/AlertMinor.svg

-1
This file was deleted.

polaris-icons/icons/AlertMinor.yml

-18
This file was deleted.
File renamed without changes.
+12
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
name: Alert triangle
2+
description: Used to represent risk associated with orders.
3+
keywords:
4+
- risk
5+
- warning
6+
- triangle
7+
- alert
8+
authors:
9+
- Adam Whitcroft
10+
- Joe Thomas
11+
date_added: 2018-11-14
12+
date_modified: 2023-06-23

polaris-icons/icons/AnalyticsBarHorizontalMinor.yml

-13
This file was deleted.

0 commit comments

Comments
 (0)