Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icon]: New icon <Reward> #11259

Closed
zecarlostorre opened this issue Nov 29, 2023 · 2 comments
Closed

[Icon]: New icon <Reward> #11259

zecarlostorre opened this issue Nov 29, 2023 · 2 comments
Assignees
@zecarlostorre
Labels
Icon Polaris iconography untriaged

Comments

@zecarlostorre
Copy link
Contributor

How will these icons be used?

Image

Icon name

Reward

What type of icon set?

Major (20x20)

Icon description

Used to represent the concept of a reward, prize or loyalty.

Reward.svg.zip

Icon keywords

rewards, loyalty, incentive, bonus, perks, benefits, appreciation, prize, recognition

Icon author

José Torre

Icon Figma link

https://www.figma.com/file/fVIazfJNe3AOJTJmBKgTO9/Polaris-Gen-3-Icons?type=design&node-id=23340-40&mode=design&t=dGBwhRfSWsqGo3dq-4

Icon SVG code

Attached it above.

Are there any other important details?

No response
@zecarlostorre zecarlostorre self-assigned this Nov 29, 2023
@alex-page
Copy link
Member

Closed by 83016e5

@alex-page alex-page reopened this Dec 10, 2023
@alex-page alex-page mentioned this issue Dec 10, 2023
Merged
@alex-page
Copy link
Member

Reopened the issue to make it clear this is a part of #11138

alex-page added a commit that referenced this issue Jan 15, 2024
@alex-page @sam-b-rose
@aaronccasanova @bratsos
@shopify/polaris-icons v8.0.0 (#11138)
f91c4b6 
> [!Warning]
> This includes multiple breaking changes to `@shopify/polaris-icons`.
Do not merge until this is thoroughly tested and approved by internal
consuming teams.

### What this PR does

Removed Major and Minor icon sizing. All icons are the same size.

Added `BillIcon`, `BillFilledIcon`, `LogoCriteo`, `LogoMeta`,
`LogoGoogle`, `MetaobjectFilledIcon`, `PriceListIcon` and
`PriceListFilledIcon`

Updated icon design for `JobsIcon`, `JobsFilledIcon`, `AutomationIcon`,
`AutomationFilledIcon`, `GiftCardIcon`, `InventoryFilledIcon`,
`ReportsIcon`, `ShipmentFilledIcon`, `AppsFilledIcon`, `MarketsIcon`,
`MarketsFilledIcon`, `BillingStatementDollarFilledIcon`,
`BillingStatementEuroFilledIcon`, `BillingStatementPoundFilledIcon`,
`BillingStatementRupeeFilledIcon`, `BillingStatementYenFilledIcon`,
`LegalFilledIcon`, `IdentityCardIcon`, `IdentityCardFilledIcon`,
`DomainsIcon`, `DomainNewIcon`, `DomainsFilledIcon`, `StoreIcon`,
`OnlineStoreIcon`, `ManagedStoreIcon`, `ImportStoreIcon`, `TaxIcon`,
`TaxFilledIcon`, `PackageFilledIcon`, `LocationIcon`,
`LocationFilledIcon`, `InactiveLocationIcon`, `PinIcon`, `GlobeIcon`,
`TransportIcon`, `NatureIcon`, `FoodIcon`, `ColorsIcon`

Removed icons `ReportFilledMinor`, `ReportMinor`, `ListMajor`,
`ListFilledMajor`

Removed `version` and `set` from icon `.yml` files

---

Closes #11259
Closes #11088

---------

Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
Co-authored-by: Aaron Casanova <aaron.casanova@shopify.com>
Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Co-authored-by: Alex Bratsos <12677111+bratsos@users.noreply.github.com>
ascherkus pushed a commit to ascherkus/polaris that referenced this issue Feb 19, 2025
@alex-page @sam-b-rose
@aaronccasanova @bratsos
@shopify/polaris-icons v8.0.0 (Shopify#11138)
24ad69a 
> [!Warning]
> This includes multiple breaking changes to `@shopify/polaris-icons`.
Do not merge until this is thoroughly tested and approved by internal
consuming teams.

### What this PR does

Removed Major and Minor icon sizing. All icons are the same size.

Added `BillIcon`, `BillFilledIcon`, `LogoCriteo`, `LogoMeta`,
`LogoGoogle`, `MetaobjectFilledIcon`, `PriceListIcon` and
`PriceListFilledIcon`

Updated icon design for `JobsIcon`, `JobsFilledIcon`, `AutomationIcon`,
`AutomationFilledIcon`, `GiftCardIcon`, `InventoryFilledIcon`,
`ReportsIcon`, `ShipmentFilledIcon`, `AppsFilledIcon`, `MarketsIcon`,
`MarketsFilledIcon`, `BillingStatementDollarFilledIcon`,
`BillingStatementEuroFilledIcon`, `BillingStatementPoundFilledIcon`,
`BillingStatementRupeeFilledIcon`, `BillingStatementYenFilledIcon`,
`LegalFilledIcon`, `IdentityCardIcon`, `IdentityCardFilledIcon`,
`DomainsIcon`, `DomainNewIcon`, `DomainsFilledIcon`, `StoreIcon`,
`OnlineStoreIcon`, `ManagedStoreIcon`, `ImportStoreIcon`, `TaxIcon`,
`TaxFilledIcon`, `PackageFilledIcon`, `LocationIcon`,
`LocationFilledIcon`, `InactiveLocationIcon`, `PinIcon`, `GlobeIcon`,
`TransportIcon`, `NatureIcon`, `FoodIcon`, `ColorsIcon`

Removed icons `ReportFilledMinor`, `ReportMinor`, `ListMajor`,
`ListFilledMajor`

Removed `version` and `set` from icon `.yml` files

---

Closes Shopify#11259
Closes Shopify#11088

---------

Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
Co-authored-by: Aaron Casanova <aaron.casanova@shopify.com>
Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Co-authored-by: Alex Bratsos <12677111+bratsos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zecarlostorre zecarlostorre

Labels
Icon Polaris iconography untriaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alex-page @zecarlostorre