Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v12-react-update-component-prop-{space,border,shadow} migration #10984

Closed

Conversation

sophschneider
Copy link
Contributor

This PR introduces a v12-react-update-component-prop-space, v12-react-update-component-prop-border, v12-react-update-component-prop-shadow migrations that targets and updates a collection of Polaris component props using v11 token aliases.

Note: This is a companion to the v12-replace-custom-property-color migration and consumes it's replacement maps for consistency.

Example usage:

npx @shopify/polaris v12-react-update-component-prop-space '**/*.{ts,tsx}'

@sophschneider sophschneider force-pushed the update-component-prop-space branch 2 times, most recently from dc66310 to b6438bd Compare October 13, 2023 18:36
@sophschneider
Copy link
Contributor Author

/snapit

@sophschneider sophschneider force-pushed the update-component-prop-space branch from b6438bd to 486a0e8 Compare October 13, 2023 19:16
@sophschneider
Copy link
Contributor Author

/snapit

@sophschneider sophschneider force-pushed the update-component-prop-space branch from 486a0e8 to 2cd5b22 Compare October 13, 2023 19:39
@sophschneider
Copy link
Contributor Author

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @sophschneider! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20231013194159
yarn add @shopify/polaris@0.0.0-snapshot-release-20231013194159

@sophschneider
Copy link
Contributor Author

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @sophschneider! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20231024151300
yarn add @shopify/polaris@0.0.0-snapshot-release-20231024151300

@aaronccasanova aaronccasanova force-pushed the update-component-prop-color branch from 35b16e1 to 652c9f7 Compare April 19, 2024 21:52
@aaronccasanova aaronccasanova force-pushed the update-component-prop-space branch from 2cd5b22 to 208ee18 Compare April 19, 2024 21:52
Copy link
Contributor

Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant