Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IndexTable] Change scroll bar container z-index so that it is under the Card shadow bevel #11411

Merged
merged 2 commits into from
Jan 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/green-owls-study.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Changed `IndexTable` scroll bar container z-index so that it is under the `Card` shadow bevel
Original file line number Diff line number Diff line change
Expand Up @@ -1381,7 +1381,7 @@ $scroll-bar-size: var(--p-space-200);

.ScrollBarContainer {
// stylelint-disable-next-line -- Polaris component custom properties
--pc-index-table-scroll-bar: 35;
--pc-index-table-scroll-bar: 30;
position: sticky;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
z-index: var(--pc-index-table-scroll-bar);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
useBreakpoints,
InlineStack,
LegacyCard,
Card,
EmptySearchResult,
IndexFilters,
useSetIndexFiltersMode,
Expand Down Expand Up @@ -1894,7 +1895,7 @@ export function WithStickyLastColumn() {
);

return (
<LegacyCard>
<Card padding="0">
<IndexTable
condensed={useBreakpoints().smDown}
resourceName={resourceName}
Expand Down Expand Up @@ -1924,7 +1925,7 @@ export function WithStickyLastColumn() {
>
{rowMarkup}
</IndexTable>
</LegacyCard>
</Card>
);
}

Expand Down