-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding performance mark to PageSkeleton unmount for load tracking. #11492
Conversation
🫰✨ Thanks @alex-page! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20240124001003 yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20240124001003 yarn add @shopify/polaris@0.0.0-snapshot-release-20240124001003 yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20240124001003 yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20240124001003 |
/snapit |
🫰✨ Thanks @craigbrunner! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20240124210446 yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20240124210446 yarn add @shopify/polaris@0.0.0-snapshot-release-20240124210446 yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20240124210446 yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20240124210446 |
Co-authored-by: Lo Kim <lo.kim@shopify.com>
bf060bb
to
face442
Compare
Localization quality issues found The following issues may affect the quality of localized translations if they are not addressed:
Please look out for other instances of this issue in your PR and fix them as well if possible. Questions about these messages? Hop in the #help-localization Slack channel. |
We have added this to Dev UI by wrapping loader timings. |
WHY are these changes introduced?
This allows us to measure how long it takes from start of pageload to page skeleton removal without refactoring a large amount of code.
WHAT is this pull request doing?
Adds a performance mark when the page skeleton is unmounted. There is no accessibility impact or extra documentation on this, so I didn't tophat those.
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.md
with documentation changes