Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding performance mark to PageSkeleton unmount for load tracking. #11492

Closed
wants to merge 6 commits into from

Conversation

craigbrunner
Copy link

@craigbrunner craigbrunner commented Jan 24, 2024

WHY are these changes introduced?

This allows us to measure how long it takes from start of pageload to page skeleton removal without refactoring a large amount of code.

WHAT is this pull request doing?

Adds a performance mark when the page skeleton is unmounted. There is no accessibility impact or extra documentation on this, so I didn't tophat those.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

Copy link
Contributor

🫰✨ Thanks @alex-page! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20240124001003
yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20240124001003
yarn add @shopify/polaris@0.0.0-snapshot-release-20240124001003
yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20240124001003
yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20240124001003

@craigbrunner
Copy link
Author

/snapit

Copy link
Contributor

🫰✨ Thanks @craigbrunner! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20240124210446
yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20240124210446
yarn add @shopify/polaris@0.0.0-snapshot-release-20240124210446
yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20240124210446
yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20240124210446

@craigbrunner craigbrunner marked this pull request as ready for review January 25, 2024 17:11
@craigbrunner craigbrunner requested a review from a team January 25, 2024 17:32
Co-authored-by: Lo Kim <lo.kim@shopify.com>
@aaronccasanova aaronccasanova force-pushed the craigbrunner/skeleton_unmount_mark branch from bf060bb to face442 Compare April 19, 2024 21:52
@github-actions github-actions bot added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Apr 19, 2024
@translation-platform
Copy link
Contributor

Localization quality issues found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Clear for key Polaris.ActionList.SearchField.clearButtonLabel is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
  • The value Search for key Polaris.ActionList.SearchField.search is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
  • The value Search actions for key Polaris.ActionList.SearchField.placeholder is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

@craigbrunner
Copy link
Author

We have added this to Dev UI by wrapping loader timings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-needed Added by a bot. Contributor needs to sign the CLA Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants