Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update background-color & border radius for new design language #3344

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

AndrewMusgrave
Copy link
Member

WHY are these changes introduced?

Adjusts border radius and darkens the background color

Without NDL

Screen Shot 2020-09-30 at 3 30 03 PM

After changes with NDL

Screen Shot 2020-09-30 at 3 33 14 PM

Currently with NDL

Screen Shot 2020-09-30 at 3 34 01 PM

WHAT is this pull request doing?

Updated border radius / background color

@AndrewMusgrave AndrewMusgrave added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Sep 30, 2020
@github-actions
Copy link
Contributor

🟡 This pull request modifies 1 files and might impact 4 other files. This is an average splash zone for a change, remember to tophat areas that could be affected.

Details:
All files potentially affected (total: 4)
🎨 src/components/Tag/Tag.scss (total: 4)

Files potentially affected (total: 4)

@jessebc
Copy link

jessebc commented Oct 1, 2020

I made a pr here to support the states in this component.

Shopify/polaris-tokens#155

@AndrewMusgrave AndrewMusgrave merged commit 531e6e1 into master Oct 1, 2020
@AndrewMusgrave AndrewMusgrave deleted the ndl-tags-background-border branch October 1, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants