-
Notifications
You must be signed in to change notification settings - Fork 45.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forge): Unbreak forge
agent
#7196
Conversation
✅ Deploy Preview for auto-gpt-docs canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7196 +/- ##
===========================================
- Coverage 39.97% 21.27% -18.70%
===========================================
Files 103 62 -41
Lines 6601 3454 -3147
Branches 979 447 -532
===========================================
- Hits 2639 735 -1904
+ Misses 3855 2679 -1176
+ Partials 107 40 -67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
forge/forge/agent/agent.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-> protocol_agent.py
or
-> forge/agent_protocol/agent.py
if you think that makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to forge/agent_protocol/agent.py
forge/forge/agent/forge_agent.py
Outdated
""" | ||
task = await super().create_task(task_request) | ||
logger.info( | ||
f"📦 Task created: {task.task_id} " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f"📦 Task created: {task.task_id} " | |
f"📦 Task created with ID {task.task_id} and " |
Pretty clean! Nice :) |
forge/forge/agent/agent_test.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file should be moved to where agent.py is now
@@ -24,7 +24,7 @@ | |||
) | |||
|
|||
if TYPE_CHECKING: | |||
from forge.agent.agent import ProtocolAgent | |||
from forge.agent_protocol.agent import ProtocolAgent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
from forge.agent_protocol.agent import ProtocolAgent | |
from .agent import ProtocolAgent |
forge/forge/agent/agent_test.py
Outdated
@@ -13,7 +13,7 @@ | |||
from forge.file_storage.base import FileStorageConfiguration | |||
from forge.file_storage.local import LocalFileStorage | |||
|
|||
from .agent import ProtocolAgent | |||
from ..agent_protocol.agent import ProtocolAgent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from ..agent_protocol.agent import ProtocolAgent | |
from forge.agent_protocol.agent import ProtocolAgent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the agent_test.py
and updated imports
@kcze can we work on getting this ready to merge asap? Lots of complaints lol |
Fixes #7154 |
Background
After refactor #7117 agents created using forge don't work.
Changes 🏗️
Revert some changes to fix forge agents and enable rudimentary components support for them. LLM calls aren't supported because the providers are in
autogpt
.forge
Agent
toProtocolAgent
(it's providing agent protocol server)forge/app.py
andforge/agent/forge_agent.py
ForgeAgent
inherits fromBaseAgent
, supports component execution and runs the same pipelines asautogpt
Agent
0.1.0
to0.2.0
PR Quality Scorecard ✨
+2 pts
+5 pts
+5 pts
+5 pts
-4 pts
+4 pts
+5 pts
-5 pts
agbenchmark
to verify that these changes do not regress performance?+10 pts