Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.1] Set LangVersion=12 unconditionally #2896

Merged
merged 3 commits into from
Mar 4, 2025
Merged

[3.1] Set LangVersion=12 unconditionally #2896

merged 3 commits into from
Mar 4, 2025

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Mar 3, 2025 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

release/3.1.x references an old SharedInfrastructure commit with LangVersion set to 10.0 we need to overwrite it with 12.0 to make the builds pass.

@antonfirsov antonfirsov changed the title [3.1] Set LangVersion in ImageSharp.csproj [3.1] Set LangVersion=12 unconditionally Mar 4, 2025
@antonfirsov antonfirsov mentioned this pull request Mar 4, 2025
Open
4 tasks
@JimBobSquarePants JimBobSquarePants merged commit 520e597 into release/3.1.x Mar 4, 2025
8 checks passed
@JimBobSquarePants JimBobSquarePants deleted the af/fix-3.1-build branch March 4, 2025 23:46
@bennetrr bennetrr mentioned this pull request Mar 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonfirsov @JimBobSquarePants