join ffbs-mesh-vpn-parker with ffbs-parker-nextnode #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmithChart
force-pushed
the
topic/parker
branch
2 times, most recently
from
f86773c to
e66c9d8
Compare
|
Thx for the input. For some reason I did not see the mail notification for this PR. I will try to integrate this changes into my PRs on community-packages. |
SmithChart
reviewed
Nov 7, 2024
|
Can you rebase onto my recent topic branch? |
SmithChart
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds requirements to ffbs-mesh-vpn-parker to include the other parker-related packages.
It should be possible to build it with the state of https://github.com/ffac/gluon/tree/v2023.2.x-parker which did revert the mesh-vpn related commits from the parker rebase.
A site-configuration then only needs to require
ffbs-mesh-vpn-parkerto work when build from a parker gluon branch.This change is backward compatible by providing the former name in the Makefile as well
Note: not tested yet