Expose compositor from subcompositor #429
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements one way of exposing a
WlCompositor
from aSubcompositorState
.To avoid a potential XY problem, here's my situation:
I want to change the input region of a (sub)surface of a wayland frame. I only have access to a
SubcompositorState
. To change the input region, I need to create new regions that I can pass intoset_input_region
. SCTK only allows the creation of new regions through a compositor, but not through a subcompositor.See:
Is exposing the compositor from the subcompositor the correct way of going about this, and if so, is my solution good?
By implementing
ProvidesBoundGlobal
, I can leverage theRegion
abstraction from SCTK: https://docs.rs/smithay-client-toolkit/latest/smithay_client_toolkit/compositor/struct.Region.html#method.new