Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQSCANGHA-40 Revert cleanup.sh to reset file access to the root folder #132

Merged
merged 1 commit into from
Jul 2, 2024
Merged

SQSCANGHA-40 Revert cleanup.sh to reset file access to the root folder #132

merged 1 commit into from
Jul 2, 2024

Conversation

henryju
Copy link
Member

@henryju henryju commented Jul 2, 2024

No description provided.

@henryju henryju force-pushed the jh/reproduce_cache_permission_issue branch from fb7834d to 0d4281a Compare July 2, 2024 08:43
@csaba-feher-sonarsource csaba-feher-sonarsource force-pushed the jh/reproduce_cache_permission_issue branch from 0d4281a to 916eac8 Compare July 2, 2024 09:12
@csaba-feher-sonarsource csaba-feher-sonarsource changed the title Add an IT with GitHub Cache action SQSCANGHA-40 Revert cleanup.sh to reset file access to the root folder Jul 2, 2024
@csaba-feher-sonarsource csaba-feher-sonarsource marked this pull request as ready for review July 2, 2024 09:21
csaba-feher-sonarsource
csaba-feher-sonarsource approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@csaba-feher-sonarsource csaba-feher-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have pairprogrammed with Julien, the change was reviewed on the way.

Note: the test is more for listing access rights there is no validation possible.
The comments were required to make sure that we not revert this functionality again.

@csaba-feher-sonarsource csaba-feher-sonarsource merged commit aecaf43 into master Jul 2, 2024
9 checks passed
@henryju henryju deleted the jh/reproduce_cache_permission_issue branch September 24, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csaba-feher-sonarsource csaba-feher-sonarsource csaba-feher-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryju @csaba-feher-sonarsource