SQSCANGHA-54 Rebranding #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonioaversa
force-pushed
the
antonio/rebranding
branch
from
020b7e4 to
2c410e9
Compare
antonioaversa
force-pushed
the
antonio/rebranding
branch
3 times, most recently
from
27a21d0 to
7f30be4
Compare
antonioaversa
force-pushed
the
antonio/support-for-missing-wget
branch
from
51a9d67 to
a9c2193
Compare
antonioaversa
force-pushed
the
antonio/rebranding
branch
from
7f30be4 to
6562c6f
Compare
henryju
approved these changes
Nov 28, 2024
README.md
Outdated
| - *`GITHUB_TOKEN` – Provided by Github (see [Authenticating with the GITHUB_TOKEN](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/authenticating-with-the-github_token)).* | ||
| - `SONAR_HOST_URL` – **Required** this tells the scanner where SonarQube is hosted. | ||
| - For SonarQube Server: you can set the `SONAR_HOST_URL` environment variable in the "Variables" settings page of your repository, or you can add them at the level of your GitHub organization (recommended). | ||
| - For SonarQube Cloud: it should be set to `https://sonarcloud.io`. |
There was a problem hiding this comment.
This is the default for new scanners, so I think you can drop this line.
There was a problem hiding this comment.
Oh, I didn't know, that's great! I have changed to text to reflect that.
This simplifies the migration of users from sonarcloud-github-action to sonarqube-scan-action, as, apart from the change of action, it should work out of the box without any argument or env var change, so it's basically a drop-in replacement!
README.md
Outdated
| - `SONAR_HOST_URL` – **Required** this tells the scanner where SonarQube is hosted. | ||
| - For SonarQube Server: you can set the `SONAR_HOST_URL` environment variable in the "Variables" settings page of your repository, or you can add them at the level of your GitHub organization (recommended). | ||
| - For SonarQube Cloud: it should be set to `https://sonarcloud.io`. | ||
| - `SONAR_ROOT_CERT` – Holds an additional root certificate (in PEM format) that is used to validate the SonarQube Server certificate. You can set the `SONAR_ROOT_CERT` environment variable in the "Secrets" settings page of your repository, or you can add them at the level of your GitHub organization (recommended). |
There was a problem hiding this comment.
Can also be useful for SonarQube Cloud, in case of a proxy.
There was a problem hiding this comment.
Indeed, I have changed the text to reflect that.
antonioaversa
force-pushed
the
antonio/rebranding
branch
from
c818325 to
32fe329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebrand the GitHub Action as "SonarQube Server and Cloud". Main changes are:
Prerequisite for the deprecation of the GitHub Action for SonarCloud.
The base of this PR is #151, as it builds on top of it.The PR is kept in draft to avoid accidental merging.#151 has been merged, so this PR now targets
dev.