Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQCPPGHA-9 Extend action to support C, C++, and Objective-C projects #161

Merged
merged 8 commits into from
Dec 16, 2024

Conversation

antonioaversa
Copy link
Contributor

@antonioaversa antonioaversa commented Dec 11, 2024

SQCPPGHA-9

Related PR on sonarqube-github-c-cpp side: SonarSource/sonarqube-github-c-cpp#21

Content of this PR:

  • sub-action install-build-wrapper to download the Build Wrapper from SonarQube (Server or Cloud) and install it locally
  • sub-action deprecated-c-cpp, where sonarqube-github-c-cpp (and indirectly sonarcloud-github-c-cpp) will forward to
  • update of the README.md to include examples for C, C++, and Objective-C projects
  • introduction of a sonar-scanner-version file at the root of the repo, with URLs and SHAs of the Sonar Scanner CLI
  • version_update.yml workflow, to periodically update sonar-scanner-version with the latest URLs and SHAs
  • QA tests for sub-actions and scripts
  • actions/cache@v4.0.2 changed into actions/cache@v4 due to this deprecation notice

Successful runs of SQS projects (only the ones on Linux since tests use a dockerized SQS, not available on Windows and macOS):

Successful runs of SQC projects:

@antonioaversa antonioaversa force-pushed the antonio/SQCPPGHA-9-rebranding-and-forward branch from e9d4e0c to 9e1b74e Compare December 11, 2024 17:20
@antonioaversa antonioaversa requested a review from a team December 11, 2024 18:22
@antonioaversa antonioaversa marked this pull request as ready for review December 11, 2024 18:23
Copy link
Member

@henryju henryju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments then LGTM, but I think someone from the Cfamily squad should review the c-cpp action more carefully than I did.

@antonioaversa antonioaversa force-pushed the antonio/SQCPPGHA-9-rebranding-and-forward branch from e2fbcf3 to 258957a Compare December 12, 2024 10:29
@antonioaversa antonioaversa force-pushed the antonio/SQCPPGHA-9-rebranding-and-forward branch from 7665391 to db6f5ff Compare December 12, 2024 16:54
@antonioaversa antonioaversa force-pushed the antonio/SQCPPGHA-9-rebranding-and-forward branch from b58b06a to 318e7c9 Compare December 12, 2024 18:26
@antonioaversa antonioaversa enabled auto-merge (squash) December 16, 2024 09:23
@antonioaversa antonioaversa merged commit 00e62e1 into master Dec 16, 2024
51 checks passed
@antonioaversa antonioaversa deleted the antonio/SQCPPGHA-9-rebranding-and-forward branch December 16, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants