Update dbus_mpris to rspotify 0.12.0 #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 30, 2023 17:59
rspotify 0.11.7 switched completely from std Duration to chrono::Duration, so update our usage accordingly. 0.11.7 also add Collectionyourepisodes to the Type enum, so add it to uri_to_id.
eladyn
previously approved these changes
Sep 3, 2023
src/dbus_mpris.rs
Outdated
| let _ = | ||
| sp_client.seek_track(new_pos as u32, playback.device.id.as_deref()); | ||
| let _ = sp_client.seek_track( | ||
| Duration::milliseconds(new_pos), |
There was a problem hiding this comment.
Haven't thought about it properly, but now that they're using Durations for seek_track (again?), would it maybe be nicer to convert our input (new_pos) to a Duration and do the addition with the Durations?
and also resolve lint errors related to try_into() Signed-off-by: Bailey Kasin <baileykasin@gmail.com>
|
Resolved the lint error from the previous commit, and then changed
|
eladyn
reviewed
Sep 19, 2023
|
Looking at CI, it seems like we might need a MSRV bump? Would you be able to update that in the CI as well as in the Cargo.toml? |
Signed-off-by: Bailey Kasin <baileykasin@gmail.com>
|
It looks like the version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest my main motivation for this is that my
cargoisn't obeying the .toml and keep pulling rspotify 0.11.7 which breaks mpris, and now that 0.12.0 is released it feels like it makes more sense to update to that than to 0.11.7.0.11.7 switched completely from std::time::Duration to chrono::Duration, so update our usage accordingly.
0.11.7 also added Collectionyourepisodes to the Type enum, so add it to uri_to_id.
0.12.0 added an optional Market for country code, which for now is just to None in the one spot it was required to be set.