Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #695

Closed
wants to merge 5 commits into from
Closed

Update dependencies #695

wants to merge 5 commits into from

Conversation

JojiiOfficial
Copy link
Member

Tried to update as much dependencies as possible without breaking. Some adjustments in the src files were made. Mpris works for me. Some versions can't be updated unless we change some bigger parts of the code.

Closes #688, #627, #624, #305, #596

@slondr
Copy link
Member

slondr commented Oct 22, 2020

What's up with the stuff about matches! reported by https://github.com/Spotifyd/spotifyd/pull/695/checks?check_run_id=1294697342?

@JojiiOfficial
Copy link
Member Author

Oh yeah lint 'errors'. I can fix them.

robinvd
robinvd previously approved these changes Nov 11, 2020
This was referenced Nov 11, 2020
@robinvd robinvd requested review from Plecra, slondr and a team January 12, 2021 15:14
@robinvd
Copy link
Contributor

robinvd commented Jan 12, 2021

@JojiiOfficial the lint errors should be fixed in a seperate PR, if you could update the conflicts? i think just removing the 'fix lint errors' commit should fix it

@JojiiOfficial
Copy link
Member Author

Removing the commit wasn't enough since #746 replaced the 'match block' with a 'matches macro' so I fixed the conflicts manually.

@robinvd robinvd requested a review from a team January 13, 2021 14:34
@slondr
Copy link
Member

slondr commented Jan 13, 2021

Seems like this PR missed the removal of `failure' from Cargo.toml, which was merged yesterday

@stale
Copy link

stale bot commented Apr 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issues that will not be fixed under any circumstances label Apr 14, 2021
@stale stale bot closed this Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix Issues that will not be fixed under any circumstances
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants