145 recommendation task cancelling #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mendation-task-cancelling
…ter abort. TODO: check and delete if possible
…t updated progress
kenmeacham
commented
Mar 13, 2024
There was a problem hiding this comment.
@panositi - Just some initial observations on the code in 145 branch
...main/java/uk/ac/soton/itinnovation/security/systemmodeller/semantics/ModelObjectsHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/ac/soton/itinnovation/security/systemmodeller/rest/ModelController.java
Outdated
Show resolved
Hide resolved
...va/uk/ac/soton/itinnovation/security/modelvalidator/attackpath/RecommendationsAlgorithm.java
Outdated
Show resolved
Hide resolved
…sociated unit test. Recommendations are only used as an async job
… check for "FINISHED" status, otherwise test may never complete
Merge recommendations timeout branch into main 145 branch
|
kenmeacham
merged commit 87b5d8b
into
67-add-control-strategy-recommendations
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.