Track client-initiated shutdown for any pipe type #2814
Merged
+11
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I'm not set on using |
|
The branch name is wrong; this actually fixes #2652. |
|
The PR CI job succeeded the first time: https://github.com/StackExchange/StackExchange.Redis/actions/runs/11786652807 |
|
@bgrainger will you try reruning CI and merging? Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2652
Previously,
RecordQuitonly recorded a client-initiatedQUITif_ioPipewas aSocketConnection, which is not true when using SSL.Since there is a 1-1 relationship between
PhysicalConnectionand_ioPipe, store whether the client initiated the shutdown on thePhysicalConnectionobject instead of (only) delegating it toSocketConnection.The line
var pipe = connectingPipe ?? _ioPipeseems irrelevant to this PR becauseconnectingPipeis only set once, inConnectedAsync, and would be relevant only if an exception were thrown between whenpipeis set and when its value is assigned to_ioPipe(i.e., between lines 1612-15).