Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run builds on PRs targeting master branch #922

Merged
merged 4 commits into from
Nov 1, 2020
Merged

Conversation

MaxHorstmann
Copy link
Contributor

@MaxHorstmann MaxHorstmann commented Oct 29, 2020

As a precursor to automating the entire release process, this simple workflow will just run all the builds for all PRs targeting the master branch.

Simultaneously, let's add a "Require status checks to pass before merging" branch protection rule.

This will prevent PRs from getting merged to master if they break any of the builds.

@MaxHorstmann MaxHorstmann changed the title Run builds on PRs targeting default branch master Oct 29, 2020
@MaxHorstmann MaxHorstmann changed the title master Run builds on PRs targeting master branch Oct 29, 2020
Copy link
Contributor

@atma-stackoverflow atma-stackoverflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants