Fix bug where psql isn't ready for migration #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyono
reviewed
Mar 26, 2024
| @@ -5,5 +5,7 @@ WORKDIR /migrations | |||
| COPY entrypoint.sh /entrypoint.sh | |||
| RUN chmod +x /entrypoint.sh | |||
|
|
|||
| RUN apk --update add postgresql-client | |||
jyono
approved these changes
Mar 26, 2024
czaloom
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Today, calling
make start-postgres-docker && make run-migrationsfails witherror: EOF. The issue is that postgres isn't actually ready to handle database requests when Docker opens the port; see psql issue here for more details.Improvement
Change the
wait_for_postgrescommand to wait untilpsqlis actually ready to start the migration process.Acknowledgements
Thank you to Jordan for finding the GitHub thread and solution mentioned above!