Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Tag torrents which have a tracker issue. #91

Closed
2 tasks done
onedr0p opened this issue Jan 10, 2022 · 9 comments · Fixed by #92
Closed
2 tasks done

[FR]: Tag torrents which have a tracker issue. #91

onedr0p opened this issue Jan 10, 2022 · 9 comments · Fixed by #92
Assignees
Labels
feature request New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop

Comments

@onedr0p
Copy link

onedr0p commented Jan 10, 2022

Is your feature request related to a problem? Please elaborate.

I maintain a script that does this but was wondering if this project could support the feature.

https://github.com/k8s-at-home/qbittorrent-scripts

Thanks!

Describe the solution you'd like

Unregistered torrents on trackers are hard to find in the UI. It would be nice to have those be tagged or optionally deleted.

Does your solution involve any of the following?

  • New config option
  • New command option

Describe alternatives you've considered

N/A

Who will this benefit?

Anyone that uses trackers that delete their torrents when a media file is bad or upgraded.

Additional Information

No response

@bobokun
Copy link
Collaborator

bobokun commented Jan 10, 2022

Is there something your script does qbit_manage doesn't do? It can already remove unregistered torrents and tag any potential issue torrents using the command --rem-unregistered. See full list of Commands that qbit_manage can do.

@onedr0p
Copy link
Author

onedr0p commented Jan 10, 2022

Oh cool, I came across your script but don't have much time to maintain mine... so your script automatically tags torrents with errors and then you set --rem-unregistered to remove them?

One minor improvement would be to check out the python click library, it's very cool and does a lot of neat features over just using the built in py argparse. My script has an example of this, it's very pythonic 3 😄

But thanks, I am planning to explore this more in my free time.

@bobokun
Copy link
Collaborator

bobokun commented Jan 10, 2022

No it will only tag the torrent as issue if it has an error that is not covered in the --rem-unregistered logic. The tagging happens when you run --rem-unregistered.

@onedr0p
Copy link
Author

onedr0p commented Jan 10, 2022

Sorry, I guess I am confused. --rem-unregistered will remove the torrent and tag it? What's the point in it being tagged if it's going to be removed with the same command?

@bobokun
Copy link
Collaborator

bobokun commented Jan 10, 2022

No it will only remove unregistered if any of the error messages are covered by the any of the keywords set:

'UNREGISTERED',
'TORRENT NOT FOUND',
'TORRENT IS NOT FOUND',
'NOT REGISTERED',
'NOT EXIST',
'UNKNOWN TORRENT',
'TRUMP',
'RETITLED',
'TRUNCATED',
'TORRENT IS NOT AUTHORIZED FOR USE ON THIS TRACKER'

Anything that has an error that is not covered by those keywords will be tagged as issue for manual review. If you find any unregistered torrents that are tagged as issue you can create a feature request and I can add it to the list

@onedr0p
Copy link
Author

onedr0p commented Jan 10, 2022

Ohhh! Got it thanks I guess maybe this feature request would be to tag them issue instead of deleting them.

@bobokun
Copy link
Collaborator

bobokun commented Jan 10, 2022

sure, that shouldn't be an issue

bobokun added a commit that referenced this issue Jan 11, 2022
[FR]: Tag torrents which have a tracker issue. #91
@bobokun bobokun added the status:added-to-develop Feature Request or Bug Fix is in Develop label Jan 11, 2022
@bobokun
Copy link
Collaborator

bobokun commented Jan 11, 2022

Use --tag-tracker-error or docker env variable QBT_TAG_TRACKER_ERROR to tag them. In the config you can specify what the tag is under the settings parent attribute using the tracker_error_tag subattribute. See the updated config.yml.sample in develop

@bobokun bobokun mentioned this issue Jan 11, 2022
@onedr0p
Copy link
Author

onedr0p commented Jan 11, 2022

Woah thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants