Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention default_bus configuration in installation process #103

Conversation

Zales0123
Copy link
Contributor

Fixes #100.

The only thing that worries me, is that it still would throw an exception after SymfonyFlex configuration if there is no default_bus configured (during cache:clear).
The best solution would be to run some script after configuration and before clearing cache asking "Which command bus you want to setup as default?".
But right now it's better than it was :)

@Zales0123 Zales0123 requested a review from a team as a code owner November 20, 2018 10:17
@Zales0123 Zales0123 added Bug Confirmed bugs or bugfixes. Maintenance Configurations, READMEs, releases, etc. labels Nov 20, 2018
@bartoszpietrzak1994 bartoszpietrzak1994 merged commit 1e8a523 into Sylius:master Nov 20, 2018
@Zales0123 Zales0123 deleted the mention-default-bus-configuration-in-installation branch November 26, 2018 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes. Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants