Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make entity properties protected #163

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Make entity properties protected #163

merged 1 commit into from
Oct 23, 2019

Conversation

JakobTolkemit
Copy link
Contributor

Extending entities is a pain if the properties are private. Doctrine complains about them not existing on the entity.

@JakobTolkemit JakobTolkemit requested a review from a team as a code owner October 21, 2019 15:32
@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance Configurations, READMEs, releases, etc. labels Oct 23, 2019
@Zales0123 Zales0123 merged commit 025dee4 into Sylius:master Oct 23, 2019
@Zales0123
Copy link
Contributor

Thanks, Jakob! 🎉

@JakobTolkemit JakobTolkemit deleted the make_entities_extendable branch October 24, 2019 13:52
@JakobTolkemit
Copy link
Contributor Author

When will this be released? We kinda need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JakobTolkemit @Zales0123 @lchrusciel