-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init Twig Extra component #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diimpp
reviewed
Jun 20, 2024
src/TwigExtra/src/Twig/Extension/TestFormAttributeExtension.php
Outdated
Show resolved
Hide resolved
src/TwigExtra/src/Twig/Extension/TestHtmlAttributeExtension.php
Outdated
Show resolved
Hide resolved
src/TwigExtra/tests/Unit/Twig/Extension/SortByExtensionTest.php
Outdated
Show resolved
Hide resolved
diimpp
reviewed
Jun 21, 2024
src/TwigExtra/tests/Unit/Twig/Extension/SortByExtensionTest.php
Outdated
Show resolved
Hide resolved
diimpp
reviewed
Jun 21, 2024
diimpp
reviewed
Jun 21, 2024
src/TwigExtra/tests/Unit/Twig/Extension/SortByExtensionTest.php
Outdated
Show resolved
Hide resolved
diimpp
approved these changes
Jun 21, 2024
loic425
commented
Jun 21, 2024
loic425
commented
Sep 4, 2024
"symfony/twig-bundle": "^6.4 || ^7.0" | ||
}, | ||
"conflict": { | ||
"sylius/ui-bundle": "<2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the idea is to remove these twig functions on 2.0 branch or adding a compiler pass to check if there are already exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new component is responsible of all generic Twig extension that was included the Ui bundle.
I've only need these 3 ones for now, we'll see later if we need other ones.