Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let TTTLastWordsMsg hook override default behaviour #1784

Merged
merged 5 commits into from
Mar 7, 2025
Merged

Let TTTLastWordsMsg hook override default behaviour #1784

merged 5 commits into from
Mar 7, 2025

Conversation

wgetJane
Copy link
Contributor

@wgetJane wgetJane commented Mar 7, 2025

TimGoll
TimGoll approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@TimGoll TimGoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for bringing it over to TTT2. There's one thing missing though. In the file add a placeholder hook with documentation:

---
-- your docs here
function GM:TTTLasWordsMsg(params) end

This way our doc tool can add the info to the doc page of TTT2. Thank you

@TimGoll TimGoll mentioned this pull request Mar 7, 2025
Open
@TimGoll TimGoll merged commit 5413e42 into TTT-2:master Mar 7, 2025
4 checks passed
@wgetJane
Copy link
Contributor Author

wgetJane commented Mar 7, 2025 •
edited
Loading

@TimGoll btw i cant comment in #1780 for some reason but imo it doesn't conflict with this one, but i guess maybe the TTT2AvoidLastWords hook is a little redundant after this

@wgetJane

This comment was marked as duplicate.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimGoll TimGoll TimGoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wgetJane @TimGoll