Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prettier): rollback to working version #458

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

yajo
Copy link
Contributor

@yajo yajo commented Mar 26, 2024

As you can see reported in prettier/prettier#15696, prettier 3.x won't work with plugins under the context of pre-commit. In practice, this means for us that XML won't get auto-formatted.

Pinning latest working combination.

@moduon MT-5455

@pedrobaeza
Copy link
Member

#457 is maybe the solution to the broken tests?

As you can see reported in prettier/prettier#15696, prettier 3.x won't work with plugins under the context of pre-commit. In practice, this means for us that XML won't get auto-formatted.

Pinning latest working combination.

@moduon MT-5455
@yajo yajo force-pushed the older-prettier branch from 36a2441 to 3aa60bf Compare April 2, 2024 09:55
@yajo
Copy link
Contributor Author

yajo commented Apr 2, 2024

Let's see. I rebased.

@pedrobaeza pedrobaeza merged commit 5b75518 into Tecnativa:main Apr 2, 2024
27 checks passed
@yajo yajo deleted the older-prettier branch April 3, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants