Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(ci/tdesign-component-repositories-ci): fix preview #2082

Merged
merged 2 commits into from
Mar 9, 2025

Conversation

liweijie0812
Copy link
Collaborator

@liweijie0812 liweijie0812 commented Mar 6, 2025

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(组件名称): 处理问题或特性描述 ...

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@liweijie0812 liweijie0812 force-pushed the ci/ci/tdesign-component-repositories-ci branch from 772fd06 to e648930 Compare March 6, 2025 09:57
@tdesign-bot
Copy link
Collaborator

tdesign-bot commented Mar 6, 2025

TDesign Component Repositories CI Test Open

Component Lint Test Build Preview
tdesign-vue
tdesign-vue-next
tdesign-react
tdesign-web-components
tdesign-mobile-vue
tdesign-mobile-react

@liweijie0812 liweijie0812 requested a review from Copilot March 6, 2025 11:33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR modifies the CI/CD workflow for preview deployments by refactoring the preview steps and updating the surge deployment commands.

  • Separates the preview site build (e.g. npm/pnpm run site:preview) into its own step.
  • Removes duplicated build commands from the multiline deployment sections and updates the surge command syntax.

Reviewed Changes

File Description
.github/workflows/tdesign-component-repositories-ci.yml Updates preview deployment steps for multiple projects by separating the site build and deployment commands and adjusting surge flags.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/workflows/tdesign-component-repositories-ci.yml:63

  • Ensure that separating the preview build (npm run site:preview) into its own step and removing it from the subsequent multiline command does not introduce a race condition—consider enforcing a dependency or wait if the build process is asynchronous.
- if: matrix.script == 'preview'

.github/workflows/tdesign-component-repositories-ci.yml:69

  • Confirm that the revised surge command syntax (with the flag reordering) is supported by the surge version in use, to avoid potential deployment issues.
npx surge --project _site --domain $DEPLOY_DOMAIN --token ${{ secrets.TDESIGN_SURGE_TOKEN }}
@liweijie0812 liweijie0812 force-pushed the ci/ci/tdesign-component-repositories-ci branch from e648930 to 203d166 Compare March 6, 2025 16:12
@uyarn uyarn merged commit 6c5df4a into develop Mar 9, 2025
8 checks passed
@uyarn uyarn deleted the ci/ci/tdesign-component-repositories-ci branch March 9, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants