fix(td_button): 修复设置shape为square或circle时出现overflow #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luozf12345
reviewed
Jul 26, 2024
| @@ -363,19 +363,19 @@ class _TDButtonState extends State<TDButton> { | |||
| double verticalPadding; | |||
| switch (widget.size) { | |||
| case TDButtonSize.large: | |||
| horizontalPadding = equalSide ? 12 : 20; | |||
| horizontalPadding = equalSide ? 10 : 20; | |||
There was a problem hiding this comment.
参考设计稿，这的Padding是符合设计规范的。数据溢出是因为_getIconSize的尺寸过大。IconSize的尺寸应该分别是：22,20,18,18；请修改_getIconSize(),谢谢。设计稿地址：https://codesign.qq.com/s/332865
There was a problem hiding this comment.
已通过修改_getIconSize的方法修复该问题
Luozf12345
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
#254
💡 需求背景和解决方案
修复td_button设置shape为square或circle时出现overflow right 2px
📝 更新日志
fix(td_button): 修复设置shape为square或circle时出现overflow
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单