Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug fix] fix code formatting during CI #597

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

kvedala
Copy link
Collaborator

@kvedala kvedala commented Aug 26, 2020

Description of Change

Code formatting failed in CI steps by clang-tidy. Added explicit clang-format command.

References

This is analogous to the issue TheAlgorithms/C-Plus-Plus#1032 and its corresponding solution TheAlgorithms/C-Plus-Plus#1052.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
    Tested in the above referenced PR and same commands used here as well.
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

this will help in maintaining code during debug of lint errors
@kvedala kvedala requested a review from ayaankhan98 August 26, 2020 15:16
@kvedala
Copy link
Collaborator Author

kvedala commented Aug 26, 2020

@ayaankhan98 I have tested the referenced PR in C-Plus-Plus repo thoroughly and copied the fixes here. But haven't tested thoroughly. Would appreciate if you give it a go as well. Thanks

Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me too.

@kvedala kvedala merged commit 5d0972a into TheAlgorithms:master Aug 26, 2020
@kvedala kvedala deleted the clang_fix branch August 26, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants