Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from
trunk
tobevy run web
#312base: main
Are you sure you want to change the base?
Switch from
trunk
tobevy run web
#312Changes from all commits
188e6f7
d15ce02
f963f93
c5b2cb1
a83df81
0ee7ad8
c2a704c
6bbef56
2fb207f
aa3bf2e
52b8963
2bd6bde
38005d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why we suggest that users use the Bevy CLI for native release while the
.vscode/tasks.json
still usescargo run
directly. Is VS Code special-cased to interpret the output ofcargo
commands? Also, is there a benefit tobevy run
overcargo run
for native builds, or is it just for uniformity?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, the native build and run is just a wrapper around cargo.
Consistency makes sense though, I will adjust that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the task type is set to
cargo
, so there might actually be some special handling happening. That needs to be investigated furtherThis file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.