Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize rerenders #212

Merged
merged 10 commits into from
Jan 22, 2025

Conversation

moskalakamil
Copy link
Collaborator

@moskalakamil moskalakamil commented Jan 10, 2025

Summary

Split codebase into components, and pass progress through forwardRef, to keep rerenders refresh only when they need to

Motivation

full VideoPlayer was rerendered every time progress was updated (so actually everytime video was played)

BEFORE

MPEG-4.movie.mp4

AFTER

Simulator-fixed.mp4

@moskalakamil moskalakamil merged commit 8aaa5a6 into TheWidlarzGroup:master Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant