Update drvsupport test (PCIDSK, GMT, PDS) #902
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the test to append data only looks at the number of features is not enough to test the PCIDSK driver correctly.
This PR modifies the drvsupport tests to compare the written data with the result. Ideally, the input records would be compared to the output records, but this is tricky, as some drivers add fields (e.g. the Shapefile driver adds a FID field). This PR only looks at one property (if the field type is supported), respectively checks if the coordinate is correct otherwise.
Additionally, this PR enables the OGR_PDS and OGR_GMT drivers. It looks as they were renamed with GDAL 2.x. Thus I suppose they are not often used in combination with Fiona.
Output: