-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action times out if client is listening #1579
Comments
Wow! You found the smoking gun (I think). Thank you so much Chris! We will look into this right away. |
I think this is handled by the code in |
This might fix it:
|
chrisstaite-menlo
added a commit
to chrisstaite-menlo/turbo-cache
that referenced
this issue
Feb 7, 2025
When the scheduler was updated to add the keep alive to the AwaitedAction the MemoryAwaitedActionDb was not updated to set this when a ClientKeepAlive was received. Fix the test client_reconnect_keeps_action_alive which was not performing the eviction due to optimisations in the filter_operations function which then detected the issue. Then update the ActionEvent::ClientKeepAlive event handler to update the client keep alive timestamp in the AwaitedAction. Fixes TraceMachina#1579.
5 tasks
chrisstaite-menlo
added a commit
to chrisstaite-menlo/turbo-cache
that referenced
this issue
Feb 7, 2025
When the scheduler was updated to add the keep alive to the AwaitedAction the MemoryAwaitedActionDb was not updated to set this when a ClientKeepAlive was received. Fix the test client_reconnect_keeps_action_alive which was not performing the eviction due to optimisations in the filter_operations function which then detected the issue. Then update the ActionEvent::ClientKeepAlive event handler to update the client keep alive timestamp in the AwaitedAction. Fixes TraceMachina#1579.
chrisstaite-menlo
added a commit
to chrisstaite-menlo/turbo-cache
that referenced
this issue
Feb 7, 2025
When the scheduler was updated to add the keep alive to the AwaitedAction the MemoryAwaitedActionDb was not updated to set this when a ClientKeepAlive was received. Fix the test client_reconnect_keeps_action_alive which was not performing the eviction due to optimisations in the filter_operations function which then detected the issue. Then update the ActionEvent::ClientKeepAlive event handler to update the client keep alive timestamp in the AwaitedAction. Fixes TraceMachina#1579.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The addition of client_action_timeout_s means that an action times out if a client isn't actively polling for it. However, the RBE WaitExecution allows passive polling of an action. This is not considered and therefore long actions time out an signal down this channel that they have timed out. If there is an active WaitExecution for an action then it should not be subject to the client action timeout.
The text was updated successfully, but these errors were encountered: