Document contributing to the native-cli #1625
Conversation
There was a problem hiding this comment.
+@MarcusSorealheis +@kubevalet human-readable at https://nativelink-y3s9gakb9b1k.deno.dev/docs/contribute/native-cli
Reviewable status: 0 of 2 LGTMs obtained, and 0 of 3 files reviewed, and pending CI: Bazel Dev / macos-15, Cargo Dev / macos-15, Installation / macos-14, Installation / macos-15, Local / lre-rs / macos-15, NativeLink.com Cloud / Remote Cache / macos-15, Web Platform Deployment / macos-15, macos-15 (waiting on @kubevalet and @MarcusSorealheis)
| To run the cluster: | ||
|
|
||
| ```bash | ||
| native up |
There was a problem hiding this comment.
i'm strongly of the opinion that we should just call this nativelink. I know that gives you a lot of extra work, but I think it's better for recognition. native is just a bit too broad.
There was a problem hiding this comment.
Renaming it is straightforward to rename it, but nativelink would interfere with the nativelink. If Pulumi supported rust we could theoretically create a version of nativelink that contains all of this logic behind a feature flag which could actually be a nice quality of life improvement, but it's currently not technically possible.
The trend with this CLI has been that it's gradually getting "slimmer" as more and more of the things this devcluster does is moved to Flux. As that trend continues it might be feasible to remove the entire thing at some point.
| 3. You should see an error message like: | ||
|
|
||
| ```txt | ||
| error: hash mismatch in fixed-output derivation ... |
There was a problem hiding this comment.
this is helpful.
There was a problem hiding this comment.
Reviewable status: 1 of 2 LGTMs obtained, and 0 of 3 files reviewed, and 2 discussions need to be resolved (waiting on @kubevalet)
There was a problem hiding this comment.
Dismissed @MarcusSorealheis from 2 discussions.
Reviewable status: 1 of 2 LGTMs obtained, and 0 of 3 files reviewed (waiting on @kubevalet)
| To run the cluster: | ||
|
|
||
| ```bash | ||
| native up |
There was a problem hiding this comment.
Renaming it is straightforward to rename it, but nativelink would interfere with the nativelink. If Pulumi supported rust we could theoretically create a version of nativelink that contains all of this logic behind a feature flag which could actually be a nice quality of life improvement, but it's currently not technically possible.
The trend with this CLI has been that it's gradually getting "slimmer" as more and more of the things this devcluster does is moved to Flux. As that trend continues it might be feasible to remove the entire thing at some point.
| 3. You should see an error message like: | ||
|
|
||
| ```txt | ||
| error: hash mismatch in fixed-output derivation ... |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained, and all files reviewed
This change is