Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test7 make target should be test8 given node v8 #322

Closed
jmwski opened this issue Aug 11, 2017 · 1 comment
Closed

test7 make target should be test8 given node v8 #322

jmwski opened this issue Aug 11, 2017 · 1 comment
Assignees
@jmwski

Comments

@jmwski
Copy link
Contributor

jmwski commented Aug 11, 2017

The current makefile on master has test7 as a make target. This, along with the example in test/node.paths.example should be updated to reflect the latest version of node.
@jmwski jmwski self-assigned this Aug 11, 2017
@jmwski jmwski changed the title test7 make target should be test8 to reflect latest version of node test7 make target should be test8 given node v8 Aug 11, 2017
@trentm
Copy link
Contributor

trentm commented Aug 11, 2017

https://cr.joyent.us/#/c/2381/

joyent-automation pushed a commit that referenced this issue Aug 11, 2017
#322 test7 make target should be test8 given node v8
c62a24f 
Reviewed by: Trent Mick <trent.mick@joyent.com>
Approved by: Trent Mick <trent.mick@joyent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmwski jmwski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trentm @jmwski @jordanhendricks