Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmoothMix Addition #1705

Closed
wants to merge 11 commits into from
Closed

Conversation

asarj
Copy link

@asarj asarj commented May 19, 2022

Description

Paper Link: https://arxiv.org/pdf/2111.09277.pdf
Code Repository based on paper: https://github.com/jh-jeong/smoothmix

Fixes # (issue)

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Test A
  • Test B

Test Configuration:

  • OS: Ubuntu 22.04 LTS
  • Python version: 3.7
  • ART version or commit number: 1.11.0
  • TensorFlow / Keras / PyTorch / MXNet version: PyTorch 1.11.0+cu113

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

asarj added 7 commits May 18, 2022 20:25
Signed-off-by: Ajay Sarjoo <ajay.sarjoo@outlook.com>
…ated a separate estimator for smoothmix

Signed-off-by: Ajay Sarjoo <ajay.sarjoo@outlook.com>
Signed-off-by: Ajay Sarjoo <ajay.sarjoo@outlook.com>
Signed-off-by: Ajay Sarjoo <ajay.sarjoo@outlook.com>
Signed-off-by: Ajay Sarjoo <ajay.sarjoo@outlook.com>
Signed-off-by: Ajay Sarjoo <ajay.sarjoo@outlook.com>
Signed-off-by: Ajay Sarjoo <ajay.sarjoo@outlook.com>
@asarj
Copy link
Author

asarj commented May 19, 2022

Hi @beat-buesser, created this new PR to reflect your recent suggestions from #1668 (comment) and to also avoid the git issues from the previous PR. I am currently looking into implementing the SmoothMix authors' SmoothPGD implementation inheriting from art.atttacks.attack.EvasionAttack, but will be traveling soon and I'm not sure if I will be finished with this part before then, will update this draft accordingly.

Tagging @keykholt and @rahmati for updates, and will close PR #1668. Please let me know if you have any other questions in the meanwhile

Signed-off-by: Ajay Sarjoo <ajay.sarjoo@outlook.com>
@lgtm-com
Copy link

lgtm-com bot commented May 19, 2022

This pull request introduces 3 alerts when merging 459f209 into 8df19af - view on LGTM.com

new alerts:

  • 3 for Module is imported more than once

@beat-buesser beat-buesser self-assigned this May 19, 2022
@beat-buesser beat-buesser added the enhancement New feature or request label May 19, 2022
@beat-buesser beat-buesser added this to the ART 1.11.0 milestone May 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #1705 (c366b1d) into dev_1.13.0 (8df19af) will decrease coverage by 33.22%.
The diff coverage is 53.10%.

❗ Current head c366b1d differs from pull request most recent head c415a63. Consider uploading reports for the commit c415a63 to get more accurate results

Impacted file tree graph

@@               Coverage Diff               @@
##           dev_1.13.0    #1705       +/-   ##
===============================================
- Coverage       88.09%   54.87%   -33.23%     
===============================================
  Files             259      251        -8     
  Lines           21347    23464     +2117     
  Branches         3789     3942      +153     
===============================================
- Hits            18805    12875     -5930     
- Misses           1598     9829     +8231     
+ Partials          944      760      -184     
Impacted Files Coverage Δ
...cks/evasion/adversarial_patch/adversarial_patch.py 55.88% <0.00%> (-1.70%) ⬇️
...adversarial_texture/adversarial_texture_pytorch.py 12.50% <0.00%> (-77.45%) ⬇️
...ion/imperceptible_asr/imperceptible_asr_pytorch.py 7.86% <0.00%> (-78.94%) ⬇️
..._air_flickering/over_the_air_flickering_pytorch.py 17.91% <0.00%> (-76.87%) ⬇️
art/attacks/evasion/pixel_threshold.py 19.80% <0.00%> (-71.50%) ⬇️
...ted_gradient_descent/projected_gradient_descent.py 83.78% <ø> (-13.52%) ⬇️
art/attacks/evasion/saliency_map.py 22.89% <0.00%> (-77.11%) ⬇️
art/attacks/evasion/universal_perturbation.py 27.10% <0.00%> (-65.43%) ⬇️
art/attacks/evasion/wasserstein.py 11.94% <0.00%> (-83.28%) ⬇️
art/attacks/evasion/zoo.py 12.01% <0.00%> (-71.71%) ⬇️
... and 240 more

Signed-off-by: Ajay Sarjoo <ajay.sarjoo@outlook.com>
@asarj
Copy link
Author

asarj commented May 20, 2022

Marking for review, but note that I did not implement the SmoothPGD attacker by inheriting from the EvasionAttack module (will be away for some time so not sure when I'll be able to resume working on this), but I welcome feedback otherwise

@asarj asarj marked this pull request as ready for review May 20, 2022 04:44
@lgtm-com
Copy link

lgtm-com bot commented May 20, 2022

This pull request introduces 3 alerts when merging a2ebed6 into 8df19af - view on LGTM.com

new alerts:

  • 3 for Module is imported more than once

Signed-off-by: Ajay Sarjoo <ajay.sarjoo@outlook.com>
@asarj asarj force-pushed the smoothmix-revised branch from aa6f021 to 29641b8 Compare June 15, 2022 18:35
Signed-off-by: Ajay Sarjoo <ajay.sarjoo@outlook.com>
@lgtm-com
Copy link

lgtm-com bot commented Jun 15, 2022

This pull request introduces 3 alerts when merging c415a63 into 3f106d7 - view on LGTM.com

new alerts:

  • 3 for Module is imported more than once

@beat-buesser beat-buesser modified the milestones: ART 1.11.0, ART 1.12.0 Jun 30, 2022
@beat-buesser beat-buesser modified the milestones: ART 1.12.0, ART 1.13.0 Sep 23, 2022
@beat-buesser beat-buesser changed the base branch from dev_1.11.0 to dev_1.13.0 September 26, 2022 21:42
@lgtm-com
Copy link

lgtm-com bot commented Sep 26, 2022

This pull request introduces 3 alerts when merging c415a63 into 89bf92f - view on LGTM.com

new alerts:

  • 3 for Module is imported more than once

@beat-buesser beat-buesser changed the base branch from dev_1.13.0 to main November 7, 2022 22:05
@beat-buesser beat-buesser changed the base branch from main to dev_1.13.0 November 7, 2022 22:05
@lgtm-com
Copy link

lgtm-com bot commented Nov 7, 2022

This pull request introduces 3 alerts when merging c415a63 into c366b1d - view on LGTM.com

new alerts:

  • 3 for Module is imported more than once

@lgtm-com
Copy link

lgtm-com bot commented Nov 7, 2022

This pull request introduces 3 alerts when merging c415a63 into 6ab005c - view on LGTM.com

new alerts:

  • 3 for Module is imported more than once

@beat-buesser beat-buesser removed this from the ART 1.13.0 milestone Dec 18, 2022
@f4str f4str mentioned this pull request Jan 11, 2023
13 tasks
@f4str f4str deleted the smoothmix-revised branch January 11, 2023 01:09
@beat-buesser
Copy link
Collaborator

Closing following #1988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants