-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AdversarialPatchPyTorch compatibility with YOLO estimator #2169
Fix AdversarialPatchPyTorch compatibility with YOLO estimator #2169
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev_1.15.0 #2169 +/- ##
==============================================
- Coverage 85.66% 78.10% -7.56%
==============================================
Files 306 306
Lines 27022 27026 +4
Branches 4962 4965 +3
==============================================
- Hits 23148 21109 -2039
- Misses 2602 4756 +2154
+ Partials 1272 1161 -111
|
…yTorch, updating notebook Signed-off-by: Kieran Fraser <Kieran.Fraser@ibm.com>
…yTorch, updating notebook Signed-off-by: Kieran Fraser <Kieran.Fraser@ibm.com>
…lpha in python yolo libraries. Adding test for adversarial patch Signed-off-by: Kieran Fraser <Kieran.Fraser@ibm.com>
Signed-off-by: Kieran Fraser <Kieran.Fraser@ibm.com>
c0332e1
to
7e46923
Compare
@@ -367,7 +367,7 @@ def test_compute_loss(art_warning, get_pytorch_yolo): | |||
# Compute loss | |||
loss = object_detector.compute_loss(x=x_test, y=y_test) | |||
|
|||
assert pytest.approx(11.20741, abs=0.9) == float(loss) | |||
assert pytest.approx(11.20741, abs=1.5) == float(loss) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YOLO generates inconsistent loss for the same input. Fix is to freeze batch_norm and drop_out layers. However freezing these layers results in compute_loss returning NaN for some inputs due to a known issue in the python YOLO library. See #2148 for detail.
Signed-off-by: Kieran Fraser <Kieran.Fraser@ibm.com>
…8_yolo Merging latest dev_1.15.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kieranfraser Thank you very much! The changes look good to me.
Description
Fixes #2148
Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
Test Configuration:
Checklist