Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Targeted Universal Perturbation documentation and add example notebook #2212

Merged
merged 14 commits into from
Sep 14, 2023

Conversation

Foxglove144
Copy link
Contributor

@Foxglove144 Foxglove144 commented Jul 3, 2023

Description

Enhances the documentation for the TargetedUniversalPerturbation class in ART. It includes a detailed explanation of some of the parameters in the constructor.

  • Corrected the allowed and default adversarial attacker names.
  • Explain what delta and eps do.
  • Added :raises: ValueError in the generate() method for the docs.

The added documentation improves the code's readability and helps users understand the purpose and usage of the class more effectively.

Also, I added an example notebook that uses this attack (mostly derived from the test for this attack).

Fixes # (issue)

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Test A
  • Test B

Test Configuration:

  • OS
  • Python version
  • ART version or commit number
  • TensorFlow / Keras / PyTorch / MXNet version

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Arunabh <arunabhm@protonmail.com>
Signed-off-by: Arunabh <arunabhm@protonmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

Merging #2212 (f7a3a64) into dev_1.16.0 (596aa14) will increase coverage by 1.27%.
Report is 13 commits behind head on dev_1.16.0.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@              Coverage Diff               @@
##           dev_1.16.0    #2212      +/-   ##
==============================================
+ Coverage       84.50%   85.77%   +1.27%     
==============================================
  Files             318      318              
  Lines           28338    28338              
  Branches         5161     5161              
==============================================
+ Hits            23947    24308     +361     
+ Misses           3071     2717     -354     
+ Partials         1320     1313       -7     
Files Changed Coverage Δ
...attacks/evasion/targeted_universal_perturbation.py 91.01% <ø> (ø)

... and 14 files with indirect coverage changes

Signed-off-by: Arunabh <arunabhm@protonmail.com>
Signed-off-by: Arunabh <arunabhm@protonmail.com>
@beat-buesser beat-buesser self-requested a review July 4, 2023 10:14
@beat-buesser beat-buesser self-assigned this Jul 4, 2023
@beat-buesser beat-buesser changed the base branch from main to dev_1.15.1 July 4, 2023 10:22
Signed-off-by: Arunabh <arunabhm@protonmail.com>
@Foxglove144 Foxglove144 changed the title Targeted Universal Perturbation documentation and example script Update Targeted Universal Perturbation documentation and add example script Jul 4, 2023
@Foxglove144 Foxglove144 changed the title Update Targeted Universal Perturbation documentation and add example script Update Targeted Universal Perturbation documentation and add example notebook Jul 9, 2023
@beat-buesser beat-buesser changed the base branch from dev_1.15.1 to dev_1.16.0 September 12, 2023 14:51
@beat-buesser beat-buesser added improvement Improve implementation notebooks Notebooks labels Sep 12, 2023
@beat-buesser beat-buesser added this to the ART 1.16.0 milestone Sep 12, 2023
@beat-buesser beat-buesser merged commit c048a5c into Trusted-AI:dev_1.16.0 Sep 14, 2023
@Foxglove144 Foxglove144 deleted the t-uap-fix branch December 17, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation notebooks Notebooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants