Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circular dependency in art.estimators.certification #2241

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

beat-buesser
Copy link
Collaborator

Description

This pull request removes a circular dependency in art.estimators.certification.

Fixes #2234

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Signed-off-by: Beat Buesser <bbu@aboyne.zrl.ch.ibm.com>
@beat-buesser beat-buesser self-assigned this Aug 10, 2023
@beat-buesser beat-buesser added bug Something isn't working improvement Improve implementation labels Aug 10, 2023
@beat-buesser beat-buesser added this to the ART 1.15.1 milestone Aug 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #2241 (cc5a28b) into dev_1.15.1 (509e223) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@             Coverage Diff             @@
##           dev_1.15.1    #2241   +/-   ##
===========================================
  Coverage       85.61%   85.62%           
===========================================
  Files             308      308           
  Lines           27450    27464   +14     
  Branches         5045     5045           
===========================================
+ Hits            23502    23516   +14     
  Misses           2668     2668           
  Partials         1280     1280           
Files Changed Coverage Δ
art/estimators/certification/__init__.py 100.00% <100.00%> (ø)

Copy link
Collaborator

@GiulioZizzo GiulioZizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Beat, thanks for the review and tracking down this problem! Looks good to merge for me.

@beat-buesser beat-buesser merged commit c63d5d5 into dev_1.15.1 Aug 16, 2023
@beat-buesser beat-buesser deleted the development_issue_2234 branch August 16, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement Improve implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot import name 'TensorFlowV2RandomizedSmoothing' from partially initialized module
3 participants