Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove in-place operations #2263

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Remove in-place operations #2263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions art/estimators/object_detection/pytorch_object_detector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ def _preprocess_and_convert_inputs(

if not self.channels_first:
x_tensor = torch.permute(x_tensor, (0, 3, 1, 2))
x_tensor /= norm_factor
x_tensor = x_tensor / norm_factor

# Set gradients
if not no_grad:
Expand All @@ -236,7 +236,7 @@ def _preprocess_and_convert_inputs(

if not self.channels_first:
x_preprocessed = torch.permute(x_preprocessed, (0, 3, 1, 2))
x_preprocessed /= norm_factor
x_preprocessed = x_preprocessed / norm_factor

# Set gradients
if not no_grad:
Expand Down
8 changes: 4 additions & 4 deletions art/estimators/object_detection/pytorch_yolo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ def translate_labels_x1y1x2y2_to_xcycwh(
labels[:, 2:6] = label_dict["boxes"]

# normalize bounding boxes to [0, 1]
labels[:, 2:6:2] /= width
labels[:, 3:6:2] /= height
labels[:, 2:6:2] = labels[:, 2:6:2] / width
labels[:, 3:6:2] = labels[:, 3:6:2] / height
Comment on lines +106 to +107
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary since labels is a newly created tensor. But the functionality is still the same.


# convert from x1y1x2y2 to xcycwh
labels[:, 4] -= labels[:, 2]
Expand Down Expand Up @@ -290,7 +290,7 @@ def _preprocess_and_convert_inputs(

if not self.channels_first:
x_tensor = torch.permute(x_tensor, (0, 3, 1, 2))
x_tensor /= norm_factor
x_tensor = x_tensor / norm_factor

# Set gradients
if not no_grad:
Expand All @@ -311,7 +311,7 @@ def _preprocess_and_convert_inputs(

if not self.channels_first:
x_preprocessed = torch.permute(x_preprocessed, (0, 3, 1, 2))
x_preprocessed /= norm_factor
x_preprocessed = x_preprocessed / norm_factor

# Set gradients
if not no_grad:
Expand Down
Loading